Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual Otel instrumentation for Spans #837

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

sjuarezgx
Copy link
Contributor

@genexusbot
Copy link
Collaborator

Cherry pick to beta failed, 1 conflicted file in commit 9da5ad1
  • pom.xml

@genexusbot
Copy link
Collaborator

Manual cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from ggallotti March 14, 2024 09:48
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk-extension-autoconfigure</artifactId>
<version>1.23.0-alpha</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump to version 1.36?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-bom</artifactId>
<version>1.23.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we bump to version 1.36?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to the latest.

<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>8</source>
<target>8</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why target JDK8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the JDK version.

Copy link
Member

@ggallotti ggallotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

Update io.opentelemetry libraries.
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@sjuarezgx sjuarezgx requested a review from ggallotti March 16, 2024 17:25
@sjuarezgx sjuarezgx merged commit 0106855 into master Mar 18, 2024
6 checks passed
@sjuarezgx sjuarezgx deleted the Traces__ManualInstrumentation branch March 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants