Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close JDBC logwriter when class goes out of scope #761

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Close JDBC logwriter when class goes out of scope #761

merged 2 commits into from
Aug 15, 2023

Conversation

tomas-sexenian
Copy link
Contributor

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@tomas-sexenian tomas-sexenian merged commit 07164c9 into master Aug 15, 2023
@tomas-sexenian tomas-sexenian deleted the BrokenJDBCLog branch August 15, 2023 19:12
tomas-sexenian added a commit that referenced this pull request Aug 15, 2023
@tomas-sexenian
Close JDBC logwriter when class goes out of scope (#761)
043a036 
Issue:104260
(cherry picked from commit 07164c9)
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 15, 2023
View reviewed changes
java/src/main/java/com/genexus/db/driver/GXDBDebug.java
Writer baseWriter = new FileWriter(fileName);
if (cfg.buffered)
{
baseWriter = new BufferedWriter(baseWriter);

Check failure

Code scanning / Fortify on Demand

Unreleased Resource: Streams

The function createWriter() in GXDBDebug.java sometimes fails to release a system resource allocated by FileWriter() on line 89.The program can potentially fail to release a system resource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iroqueta iroqueta iroqueta approved these changes

Assignees
No one assigned
Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomas-sexenian @genexusbot @iroqueta @cinthamo