Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the cases where url are sent in headers we dont must to sanitize it. #735

Merged
merged 2 commits into from
Jun 21, 2023
Merged

In the cases where url are sent in headers we dont must to sanitize it. #735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3299bb2
In the cases where url are sent in headers we dont must to sanitize it.
iroqueta Jun 20, 2023
7993b8a
For the moment we are not going to sanitize header values because it'…
iroqueta Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gxweb/src/main/java/com/genexus/internet/HttpAjaxContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,7 @@ public void redirect_impl(String url, IGXWindow win) {

if (isSpaRequest(true)) {
pushUrlSessionStorage();
getResponse().setHeader(GX_SPA_REDIRECT_URL, url + popLvlParm);
getResponse().setHeader(GX_SPA_REDIRECT_URL, url + popLvlParm, false);
sendCacheHeaders();
} else {
redirect_http(url + popLvlParm);
Expand Down
4 changes: 2 additions & 2 deletions java/src/main/java/com/genexus/webpanels/HttpContextWeb.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,7 +1318,7 @@ protected void redirect_http(String url) {
} else {
pushUrlSessionStorage();
if (useCustomRedirect()) {
getResponse().setHeader("Location", url);
getResponse().setHeader("Location", url, false);
getRequest().setAttribute("gx_webcall_method", "customredirect");
getResponse().setStatus(HttpServletResponse.getSC_MOVED_TEMPORARILY());
} else {
Expand All @@ -1336,7 +1336,7 @@ private void doRedirect(String url) throws IOException {
getRequest().setAttribute("gx_webcall_method", "redirect");
// getResponse().sendRedirect(url); No retornamos 302 sino 301, debido al SEO.
response.setStatus(HttpServletResponse.getSC_MOVED_PERMANENTLY());
response.setHeader("Location", url);
response.setHeader("Location", url, false);
sendCacheHeaders();
}

Expand Down