hasLongYear was giving wrong result #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick to beta success |
|
Issue originally talked about FromJSON adding/subtracting 100 years from a date but when debugging I discovered that the real problem is that when a date is assigned like &DateTime = #1800-01-01 00:00:00.000# its date format comes up as yy-MM-dd instead of a full year one and therefore the property first year of 20th century is being taken into consideration when in reality there is no need for that. |
iroqueta
previously approved these changes
Mar 3, 2023
Cherry pick to beta success |
iroqueta
approved these changes
Mar 8, 2023
tomas-sexenian
added a commit
that referenced
this pull request
Mar 10, 2023
* hasLongYear was giving wrong result Issue:101533 * Revert "hasLongYear was giving wrong result" This reverts commit 934d354. * If date's length is 23 then it's full year * ctotex tests --------- Co-authored-by: tomas-sexenian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:101533