Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mtom was not being using never. It must be used if the service do not… #642

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

iroqueta
Copy link
Collaborator

… have ws-security and logging is off

When messageContext.getMessage() is invoked Mtom is disabled, so we must invoke it only in the cases when we need it (to configure ws-security or print request and response log)
Issue: 100558

… have ws-security and logging is off

When messageContext.getMessage() is invoked Mtom is disabled, so we must invoke it only in the cases when we need it (to configure ws-security or print request and response log)
Issue: 100558
@iroqueta iroqueta requested a review from ggallotti December 13, 2022 11:52
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

Copy link
Member

@ggallotti ggallotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted just one comment in order to be safe.

messageContext.getMessage().writeTo(out);
String messageBody = new String(out.toByteArray(), "utf-8");
if (Boolean.FALSE.equals(outboundProperty)) {
messageContext.put(GX_SOAP_BODY, messageBody);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messageContext.put(GX_SOAP_BODY, messageBody); will only be executed if DEBUG is Enabled.
Is this correct? Just to be sure.
Ignore if not relevant.

@iroqueta iroqueta merged commit c7ed2e3 into master Dec 16, 2022
@iroqueta iroqueta deleted the MtomUsingHandlers branch December 16, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants