Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket & WebNotifications: Stability and Logging Improvements #591

Merged
merged 11 commits into from
Jul 25, 2022
Merged

WebSocket & WebNotifications: Stability and Logging Improvements #591

merged 11 commits into from
Jul 25, 2022

Conversation

ggallotti
Copy link
Member

@ggallotti ggallotti commented Jul 8, 2022 •
edited
Loading

We were throwing this error that would confuse Developers:

ERROR com.genexus.internet.GXWebNotification - Could not create com.genexus.internet.GXWebSocket instance. Check whether WebServer requirements are met and WebNotifications Provider Generator Property is set

The fact is that the WebSocket Server is initialized on demand only. When a outbound request is made to the entrypoint.
We were logging the misleading message when there were no configuration errors.

  • Improved general logging

Issue 97182

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@ggallotti ggallotti changed the title Stability and Logging Improvements to WebSocket implementation WebSocket & WebNotifications: Stability and Logging Improvements Jul 11, 2022
@ggallotti ggallotti requested a review from iroqueta July 11, 2022 18:58
iroqueta
iroqueta reviewed Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@iroqueta iroqueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check registerSocketService method comment

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@ggallotti
Copy link
Member Author

Ready!

@ggallotti ggallotti requested a review from iroqueta July 14, 2022 12:42
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

iroqueta
iroqueta previously approved these changes Jul 15, 2022
View reviewed changes
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@ggallotti ggallotti requested a review from iroqueta July 15, 2022 19:16
@ggallotti
Copy link
Member Author

Made some changes cc: @iroqueta

@ggallotti ggallotti merged commit 1f46b88 into master Jul 25, 2022
@ggallotti ggallotti deleted the websocket-log branch July 25, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iroqueta iroqueta iroqueta approved these changes

Assignees
No one assigned
Labels
bot closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggallotti @genexusbot @iroqueta @cinthamo