-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .editorconfig #287
Update .editorconfig #287
Conversation
I am not sure about the tab change. We might have mixed source files, and sometimes a combination of spaces and tabs is used for alignment. |
Your're right. With the existing mixed source files it's better to keep the pre configured So I've reverted the change. It's now only resorting some things in the file. So close or merge. I'm happy with both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, unfortunately the coding style we have in gen_smtp is quite special =)
It would be cool to add some code-formatter like https://github.com/WhatsApp/erlfmt one day, but the problem with it is that it messes-up with the git blame
...
Ok, I did one last quick edit. |
@cw789 is this ready for merge? |
Yes it is now. |
Thanks! |
Possibly sometime an evaluation worth. But the thing with git blame is a good point. Wouldn't have thought about that. |
Probably bikeshedding (resorting things).
But with tab the(we have mixed source files)indent_size
should be an user preference.Additionally added
.md
for possibly future guides with this extension.Removed
.conf
as nowhere seen in this repository.Changed the
indent_size
to 2 for.yml
(as it is currently used).