Add default value for ai::EmbeddingModel::embedding_model_max_batch_tokens #8406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs preview deploy✅ Successfully deployed docs preview for commit 6c39982: https://edgedb-docs-p7krakih2-edgedb.vercel.app (Last updated: Feb 26, 2025, 23:46:52 UTC) |
|
Tag for backport? |
dnwpark
force-pushed
the
ai-ext-default-value
branch
from
c748664 to
6c39982
Compare
msullivan
approved these changes
Feb 27, 2025
msullivan
added
backported-6.x
msullivan
pushed a commit
that referenced
this pull request
Feb 28, 2025
…okens (#8406) The default value is `'8191'` to match OpenAI.
msullivan
pushed a commit
that referenced
this pull request
Mar 1, 2025
…okens (#8406) The default value is `'8191'` to match OpenAI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value is
'8191'to match OpenAI.close #8400