Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize compilation in transactions #8082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize compilation in transactions #8082

wants to merge 1 commit into from

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Dec 8, 2024

Do not re-pickle state (which includes schemas and other heavy objects) on every query in transactions unless that state changes.

Do not re-pickle state (which includes schemas and other heavy
objects) on every query in transactions unless that state changes.
@1st1 1st1 requested review from msullivan, elprans and fantix December 8, 2024 02:40
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nervous about things being added without get_state_key being properly updated. Could you add some comments in places where it would be hard to miss that?

@msullivan msullivan added the to-backport-6.x PRs that *should* be backported to 6.x label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-backport-6.x PRs that *should* be backported to 6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants