Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search std for module name when using with x as module. #7836

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Oct 7, 2024

  • Allows queries such as with http as net::http select http::Response. The aliased module net::http will resolve to std::net::http.
  • Apply module aliases to function names during normalization, even if no function was found.
    • This fixes an issue where given the following modules:
      • module A { function foo() -> int64 using (1) }
      • module B {}
      • module C { alias query := (with A as B select A::foo()}
    • C::query would normalize to select A::foo() with the expectation that A::Foo does not exist.

related #7737

@dnwpark dnwpark marked this pull request as draft October 8, 2024 00:05
@dnwpark dnwpark requested a review from msullivan October 8, 2024 20:53
@dnwpark dnwpark marked this pull request as ready for review October 8, 2024 20:54
@dnwpark dnwpark requested a review from aljazerzen October 8, 2024 20:54
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this. Tests look very exhaustive.

@dnwpark dnwpark merged commit 3c03cec into master Oct 8, 2024
24 checks passed
@dnwpark dnwpark deleted the with-as-module branch October 8, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants