Cache by schema version #6847
Merged
Cache by schema version #6847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
reviewed
Feb 14, 2024
msullivan
approved these changes
Feb 14, 2024
elprans
reviewed
Feb 14, 2024
edb/server/dbview/dbview.pyx
Outdated
| state.append( | ||
| {"name": '__dbver__', "value": dbver, "type": 'C'}) | ||
| {"name": '__ver__', "value": ver, "type": 'C'}) |
There was a problem hiding this comment.
Where are we actually reading this?
There was a problem hiding this comment.
https://github.com/edgedb/edgedb/blob/669ba34661ad04a605b12f745fa4b92122557570/edb/server/protocol/execute.pyx#L88-L91 and https://github.com/edgedb/edgedb/blob/669ba34661ad04a605b12f745fa4b92122557570/edb/server/protocol/execute.pyx#L253-L256 are the relevant places.
It doesn't get used directly, but changes in it are used to force a state sync
This reverts commit 669ba34.
Also added comments to explain how to handle compilation with a concurrent schema change.
msullivan
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop integer
dbverand replace it with the UUIDschema_version, so that we can persist the query cache under consistent keys in the next steps.dbverwas bumped on config changes butschema_versionis only for user schema. We handle this difference by adding such config into the compile cache key / PG state key.get_session_config()for cache key should be optimized to honoraffects_compilation, this is fixed in a future persistent cache PR.