Drop dead code of in-transaction cache after DDL #6818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries after DDL in a transaction have been running without cache for some time, dropping the dead code for now; maybe we will add it back in the future properly.
elprans
approved these changes
Feb 12, 2024
aljazerzen
pushed a commit
that referenced
this pull request
Mar 13, 2024
Queries after DDL in a transaction have been running without cache for some time, dropping the dead code for now; maybe we will add it back in the future properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dropped dead code path was never used since:
https://github.com/edgedb/edgedb/pull/641/files#diff-1503bde887dee692dada5bf2b3a8e924233fabc6df2ca972baffe86c2581cf3cR177-R179
After the persistent cache lands, we should add this back.