Adaptive Postgres HA Support #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
reviewed
Sep 8, 2021
elprans
reviewed
Sep 8, 2021
elprans
reviewed
Sep 8, 2021
fantix
force-pushed
the
ha-passive
branch
3 times, most recently
from
9fbc961 to
42c74af
Compare
1st1
approved these changes
Sep 10, 2021
| def get_backend(parsed_dsn: urllib.parse.ParseResult) -> Optional[HABackend]: | ||
| backend, _, sub_scheme = parsed_dsn.scheme.partition("+") | ||
| if backend == "stolon": | ||
| from . import stolon |
There was a problem hiding this comment.
This was to break a circular import ha.base <-> ha.base.stolon
| self.server = server | ||
|
|
||
| def mark_as_system_db(self): | ||
| assert defines.EDGEDB_SYSTEM_DB in self.dbname |
There was a problem hiding this comment.
Why does this check use in and not ==?
There was a problem hiding this comment.
It's related to multi-tenancy: #2158
This was referenced Sep 10, 2021
* Also fixed a bug that pg message is not finished * Add comments, refine logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2580, implementation of #2887
This PR supports a "adaptive" Postgres HA cluster which doesn't actively notify EdgeDB of failovers.