Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .gel files. #1406

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add support for .gel files. #1406

merged 3 commits into from
Nov 25, 2024

Conversation

dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Nov 22, 2024

Also emit warning if .esdl files are found.

@dnwpark dnwpark requested a review from mmastrac November 22, 2024 22:43
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two minor formatting nits

src/branding.rs Outdated
@@ -37,6 +37,15 @@ pub const BRANDING_CLI_CMD_ALT_FILE: &str = if cfg!(windows) {
BRANDING_CLI_CMD_ALT
};

//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//

src/platform.rs Outdated
Comment on lines 141 to 143
}
pub fn is_schema_file(filename: &str) -> bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
pub fn is_schema_file(filename: &str) -> bool {
}
pub fn is_schema_file(filename: &str) -> bool {

@dnwpark dnwpark merged commit e80a37d into master Nov 25, 2024
17 checks passed
@dnwpark dnwpark deleted the gel-file-ext branch November 25, 2024 21:04
fantix added a commit that referenced this pull request Nov 28, 2024
Changes
=======

* Add extension commands (#1385 #1389)
  (by @mmastrac in 290579b 7de43a2)

* Add support for SQL as input query language (#1400)
  (by @elprans in ac7b368)

* Change bootstrapped user to "admin" (#1413)
  (by @fantix in c9104a5)

Binary Protocol Changes:

* Bump edgedb-protocol for protocol v2 support (#1388)
  (by @elprans in 4e7988a)

* Send query tag "gel/cli" or "gel/repl" (protocol v3, #1408)
  (by @fantix in 1e04b64)

Config Changes:

* Support scoping config params (#1382)
  (by @mmastrac in 6c93799)

* Add current_email_provider_name config. (#1409)
  (by @dnwpark in a8cd9bd)

* Add config track_query_stats (#1411)
  (by @fantix in 45187bf)

Branding
========

* Prepare to rename EdgeDB -> Gel (#1390)
  (by @mmastrac in 7e58bd2)

* Rename: all other env vars in the CLI (#1396)
  (by @mmastrac in ef33343)

* Install new executable name (and link old executable) (#1398)
  (by @mmastrac in dbc9333)

* Mopping up rest of the edgedb CLI command references  (#1402)
  (by @mmastrac in 01a912a)

* New branding on install and Repl (#1397)
  (by @mmastrac in 6a5f1c4)

* Add support for .gel files. (#1406)
  (by @dnwpark in e80a37d)

Fixes
=====

* Warnings (#1378)
  (by @aljazerzen in 4c9e89f)

* Use rustls for reqwest (#1381)
  (by @mmastrac in 8d05aa7)

* Update Cargo.lock (#1384 #1410)
  (by @aljazerzen in 75a7dfe 0427987)

* cargo clippy --fix -- -Dclippy::uninlined_format_args (#1392)
  (by @mmastrac in 1493037)

* Remove one style of printing from CLI (#1393)
  (by @mmastrac in 5c93ab7)

* Replace print::warn and print::error with macros (#1395)
  (by @mmastrac in 8367287)

* workflows: Use correct version for builds on macOS and Windows
  (by @elprans in ba1ccfd)

* Make sure bzip2 always gets linked statically
  (by @elprans in a179763)

* Bump Ubuntu _down_ to Jammy (#1405)
  (by @mmastrac in 5f22cb7)

* Fix default server user (#1412)
  (by @fantix in adc523c)
@fantix fantix mentioned this pull request Nov 28, 2024
fantix added a commit that referenced this pull request Nov 28, 2024
Changes
=======

* Add extension commands (#1385 #1389)
  (by @mmastrac in 290579b 7de43a2)

* Add support for SQL as input query language (#1400)
  (by @elprans in ac7b368)

* Change bootstrapped user to "admin" (#1413)
  (by @fantix in c9104a5)

Binary Protocol Changes:

* Bump edgedb-protocol for protocol v2 support (#1388)
  (by @elprans in 4e7988a)

* Send query tag "gel/cli" or "gel/repl" (protocol v3, #1408)
  (by @fantix in 1e04b64)

Config Changes:

* Support scoping config params (#1382)
  (by @mmastrac in 6c93799)

* Add current_email_provider_name config. (#1409)
  (by @dnwpark in a8cd9bd)

* Add config track_query_stats (#1411)
  (by @fantix in 45187bf)

Branding
========

* Prepare to rename EdgeDB -> Gel (#1390)
  (by @mmastrac in 7e58bd2)

* Rename: all other env vars in the CLI (#1396)
  (by @mmastrac in ef33343)

* Install new executable name (and link old executable) (#1398)
  (by @mmastrac in dbc9333)

* Mopping up rest of the edgedb CLI command references  (#1402)
  (by @mmastrac in 01a912a)

* New branding on install and Repl (#1397)
  (by @mmastrac in 6a5f1c4)

* Add support for .gel files. (#1406)
  (by @dnwpark in e80a37d)

Fixes
=====

* Warnings (#1378)
  (by @aljazerzen in 4c9e89f)

* Use rustls for reqwest (#1381)
  (by @mmastrac in 8d05aa7)

* Update Cargo.lock (#1384 #1410)
  (by @aljazerzen in 75a7dfe 0427987)

* cargo clippy --fix -- -Dclippy::uninlined_format_args (#1392)
  (by @mmastrac in 1493037)

* Remove one style of printing from CLI (#1393)
  (by @mmastrac in 5c93ab7)

* Replace print::warn and print::error with macros (#1395)
  (by @mmastrac in 8367287)

* workflows: Use correct version for builds on macOS and Windows
  (by @elprans in ba1ccfd)

* Make sure bzip2 always gets linked statically
  (by @elprans in a179763)

* Bump Ubuntu _down_ to Jammy (#1405)
  (by @mmastrac in 5f22cb7)

* Fix default server user (#1412)
  (by @fantix in adc523c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants