Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Resolved : UI Component listing action column outside of screen when… #20

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15459

The dropdown menu should be positioned under the link

Description

Fixed Issues (if relevant)

  1. UI Component listing action column outside of screen when too many columns magento/magento2#14153: Issue title UI Component listing action column outside of screen when too many columns

Manual testing scenarios

  1. Edit cms_page_listing.xml
       <column name="text1">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text2">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text3">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text4">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text5">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text6">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text7">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text8">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text9">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text10">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text11">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text12">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
        <column name="text13">
            <settings>
                <label translate="true">Text</label>
                <visible>true</visible>
            </settings>
        </column>
  1. Add the following snippet to the columns tag:
  2. Clear cache and empty ui_bookmark table
  3. Go to CMS page listing
  4. Resize screen to 1200px wide
  5. Scroll to the right to the actions column
  6. Click on it

Actual Result

image

Expected Result

expected

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit d595ea3 into 2.3-develop Jun 4, 2018
gelanivishal pushed a commit that referenced this pull request Aug 10, 2018
[Forwardport] Added 'title' attribute to 'a' link.
gelanivishal pushed a commit that referenced this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants