Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] #12820 - Wrong annotation in _toOptionArray - magento/framework/Data/… #17

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15336
Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Description

Set correct annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Fixed Issues (if relevant)

  1. magento/magento2#<12820>: Wrong annotation in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Manual testing scenarios

  1. Please check request parameter in _toOptionArray - magento/framework/Data/Collection/AbstractDb.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit a5fa6e3 into 2.1-develop Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants