Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button-dropdown): remove the default style and side effects under webkit #742

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

unix
Copy link
Member

@unix unix commented Feb 13, 2022

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

@unix unix self-assigned this Feb 13, 2022
@netlify
Copy link

netlify bot commented Feb 13, 2022

✔️ Deploy Preview for geist-ui ready!

🔨 Explore the source changes: 2e43db6

🔍 Inspect the deploy log: https://app.netlify.com/sites/geist-ui/deploys/62090d4988eee6000850e20b

😎 Browse the preview: https://deploy-preview-742--geist-ui.netlify.app

@unix unix added the type: bug Something isn't working label Feb 13, 2022
@unix unix linked an issue Feb 13, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #742 (0223bdb) into master (ccb839c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0223bdb differs from pull request most recent head 2e43db6. Consider uploading reports for the commit 2e43db6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
- Coverage   98.85%   98.85%   -0.01%     
==========================================
  Files         198      198              
  Lines        3046     3045       -1     
  Branches      669      669              
==========================================
- Hits         3011     3010       -1     
  Misses         34       34              
  Partials        1        1              
Impacted Files Coverage Δ
components/css-baseline/css-baseline.tsx 100.00% <ø> (ø)
components/button-dropdown/button-dropdown.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb839c...2e43db6. Read the comment docs.

@unix unix merged commit 57ef41f into geist-org:master Feb 13, 2022
@unix unix deleted the fix/button-dropdown branch February 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button Dropdown component contains an extra arrow in macOS Safari
1 participant