Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Grid component #192

Merged
merged 5 commits into from
May 9, 2020
Merged

feat: add Grid component #192

merged 5 commits into from
May 9, 2020

Conversation

unix
Copy link
Member

@unix unix commented May 9, 2020

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

resolved #187

unix added 4 commits May 10, 2020 02:40
docs(playground): fix container is not fill of parent element
docs(grid): add docs for grid
fix(grid): fix error when size exceeds limit
@unix unix marked this pull request as ready for review May 9, 2020 18:41
@unix unix added this to the Responsive layout milestone May 9, 2020
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #192 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         162      167    +5     
  Lines        2031     2069   +38     
  Branches      482      485    +3     
=======================================
+ Hits         2029     2067   +38     
  Misses          2        2           
Impacted Files Coverage Δ
components/grid/basic-item.tsx 100.00% <100.00%> (ø)
components/grid/grid-container.tsx 100.00% <100.00%> (ø)
components/grid/grid.tsx 100.00% <100.00%> (ø)
components/grid/index.ts 100.00% <100.00%> (ø)
components/styles/themes/dark.ts 100.00% <100.00%> (ø)
components/styles/themes/default.ts 100.00% <100.00%> (ø)
components/styles/themes/shared.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5179f...5073112. Read the comment docs.

@unix unix merged commit 156d383 into geist-org:master May 9, 2020
@unix unix deleted the grid branch May 9, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Grid componnet for fluid layout
1 participant