Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add templates and contributor files #2

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Add templates and contributor files #2

merged 7 commits into from
Feb 12, 2025

Conversation

townsend2010
Copy link
Collaborator

This adds all of the templates and contributor files.

Signed-off-by: Chris Townsend [email protected]

plars
plars approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that mentioning the hint you posted earlier for rebase/signoff would be a nice thing for the CONTIBUTING.md, but it could be a future improvement if this is just our standard set of things that you're adding. So +1 from me

kdaula
kdaula approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@kdaula kdaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelcarifio-public
Copy link
Collaborator

+1

@michaelcarifio-public michaelcarifio-public removed their request for review February 12, 2025 21:25
@townsend2010 townsend2010 merged commit 713ebf8 into main Feb 12, 2025
1 check passed
@townsend2010 townsend2010 deleted the add-templates-and-contribution-files branch February 12, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plars plars plars approved these changes

@kdaula kdaula kdaula approved these changes

@michaelcarifio-public michaelcarifio-public michaelcarifio-public approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@townsend2010 @michaelcarifio-public @plars @kdaula