chore(sc-tracing): fix the max_level implementation of Subscriber #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you check that 'RUST_LOG = gear' and 'RUST_LOG = gear = trace' works right? |
yeah, you can test with this branch https://github.com/gear-tech/gear/tree/cl/fix-logging |
grishasobol
approved these changes
Dec 2, 2022
ukint-vs
pushed a commit
that referenced
this pull request
Dec 10, 2022
chore(sc-tracing): fix the max_level implementation of Subscriber
ukint-vs
pushed a commit
that referenced
this pull request
Dec 20, 2022
chore(sc-tracing): fix the max_level implementation of Subscriber
ukint-vs
pushed a commit
that referenced
this pull request
Dec 22, 2022
chore(sc-tracing): fix the max_level implementation of Subscriber
ukint-vs
pushed a commit
that referenced
this pull request
Feb 13, 2023
chore(sc-tracing): fix the max_level implementation of Subscriber
ukint-vs
pushed a commit
that referenced
this pull request
Feb 13, 2023
chore(sc-tracing): fix the max_level implementation of Subscriber
gshep
added a commit
that referenced
this pull request
Apr 3, 2023
ukint-vs
pushed a commit
that referenced
this pull request
Apr 13, 2023
chore(sc-tracing): fix the max_level implementation of Subscriber
gshep
added a commit
that referenced
this pull request
Apr 13, 2023
gshep
added a commit
that referenced
this pull request
Apr 14, 2023
breathx
pushed a commit
that referenced
this pull request
Apr 22, 2023
chore(sc-tracing): fix the max_level implementation of Subscriber
gshep
pushed a commit
that referenced
this pull request
Jul 4, 2023
chore(sc-tracing): fix the max_level implementation of Subscriber
ukint-vs
pushed a commit
that referenced
this pull request
Jul 15, 2023
chore(sc-tracing): fix the max_level implementation of Subscriber
ukint-vs
pushed a commit
that referenced
this pull request
Nov 28, 2023
chore(sc-tracing): fix the max_level implementation of Subscriber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubscriberBuilder::with_max_level has side effect that replacing the previous
EnvFiliterwhich will make some of the preivous configurations invalid ( including the configurations inRUST_LOG), and since it will construct different type SubscriberBuilder from EnvFilter, we can not do it without conditional compilation...The workaround here is filitering the
RUST_LOG( we can do the same in our cli and revert 92cac9c )Tests
https://github.com/gear-tech/gear/tree/cl/fix-logging