Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the current rent functionality #3590

Merged
merged 18 commits into from
Jan 10, 2024
Merged

chore: Remove the current rent functionality #3590

merged 18 commits into from
Jan 10, 2024

Conversation

gshep
Copy link
Member

@gshep gshep commented Dec 14, 2023

Resolves #3561

@gear-tech/dev

@gshep gshep added A0-pleasereview PR is ready to be reviewed by the team D2-node Gear Node C2-refactoring Refactoring proposal labels Dec 14, 2023
@gshep gshep self-assigned this Dec 14, 2023
@NikVolf
Copy link
Member

NikVolf commented Jan 8, 2024

please rebase

Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • mark pay program rent gstd call deprecated
  • force syscall return some dumb Ok result

core-processor/src/ext.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
pallets/gear/src/manager/task.rs Show resolved Hide resolved
@breathx breathx added the A3-gotissues PR occurred to have issues after the review label Jan 8, 2024
gshep added 2 commits January 9, 2024 14:28
Conflicts:
	gsdk/src/metadata/generated.rs
	pallets/gear-debug/src/tests/mod.rs
	pallets/gear/src/benchmarking/mod.rs
	pallets/gear/src/benchmarking/tasks.rs
	pallets/gear/src/lib.rs
	pallets/gear/src/tests.rs
	pallets/gear/src/weights.rs
	runtime/vara/src/weights/pallet_gear.rs
@gshep gshep requested a review from breathx January 9, 2024 12:03
gstd/src/exec/basic.rs Outdated Show resolved Hide resolved
pallets/gear/src/lib.rs Outdated Show resolved Hide resolved
examples/syscalls/src/wasm.rs Outdated Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Jan 10, 2024
@gshep gshep merged commit fb0ea9a into master Jan 10, 2024
11 checks passed
@gshep gshep deleted the gshep/issue-3561 branch January 10, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes A3-gotissues PR occurred to have issues after the review C2-refactoring Refactoring proposal D2-node Gear Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rent logic
5 participants