StylizedLiquid godot 3.x to 4.3 conversion #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
stylized liquid godot 3 to 4.3
|
Thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted the shader here.
It all seems correct to me. Only the environment seems different, but that has nothing to do with the StylizedLiquid Scene so I didn't touch that.
Most difficult was the Bezier Animation Trackss. They were deleted when opening the Project from Godot 4.0 to 4.3, but when the 3.x project was opened in 4.4 Dev3, they wouldn't be deleted and I could save them out as a resource and bring them back to Godot 4.3. Just leaving this here for posterity or anyone else having this problem.
Potentially it would be wiser to save the materials as .tres in the future rather than .material, so they can be inspected using a text editor, and more easily upgraded