Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event series and event Fragment redesign #265

Merged
merged 18 commits into from
Mar 2, 2015
Merged

Event series and event Fragment redesign #265

merged 18 commits into from
Mar 2, 2015

Conversation

tasomaniac
Copy link
Member

  • primaryColor support for Event Series. From now on, every event series should have a color.
  • In the debug mode, IO Extended is also shown.
  • Description text of a series can be long now. It is in a ScrollView.
  • Event List items are redesigned. Please comment on this. That is one thing that I can improve.
  • Gdg.NoActionbar renamed to Theme.GDG.NoActionBar
  • Responsive width for the EventFragment in the MainActivity. We can also do 2 column here but this was faster.
  • keyline_1 and keyline_2 alignment just like in the Google IO application.
    • Hamburger icon is aligned to event icon
    • Spinner and Toolbar Title are aligned to Event Card Titles.

screenshot_2015-03-02-10-35-07
screenshot_2015-03-02-10-34-51
screenshot_2015-03-02-10-34-42

Note: After the last rebase, the backgrounds of the items in the Toolbar become blue. We should fix that.

friedger
friedger reviewed Mar 2, 2015
View reviewed changes
app/src/main/java/org/gdg/frisbee/android/app/App.java
Const.START_TIME_IOEXTENDED,
Const.END_TIME_IOEXTENDED));
}

private void addTaggedEventSeriesIfDateFits(@NonNull TaggedEventSeries taggedEventSeries) {
DateTime now = DateTime.now();
if (now.isAfter(taggedEventSeries.getStartDateInMillis())
&& now.isBefore(taggedEventSeries.getEndDateInMillis())) {
if (BuildConfig.DEBUG || (now.isAfter(taggedEventSeries.getStartDateInMillis())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@HenriqueRocha
Copy link
Contributor

Really good work you've done. I agree with @friedger comments.
I don't like the design that much but we can change that later.
At least it's much better than what we currently have. 👍

@tasomaniac
Copy link
Member Author

Thanks @HenriqueRocha
We can definitely change it later. I actually want to get icon and cover photos for all of the events. I will take a look into hub API and see what we can do there.

@mauimauer
Copy link
Member

Do you pull those colors using the Hub API. The notion of having a color attribute for event tags is something that is not supported based on the data we get from the Devsite. The Hub provides an optional color field for some tags (see: https://hub.gdgx.io/api/v1/tags/android)

A UI for Admins to add/edit Tag Metadata is pending with gdg-x/hub#18

@mauimauer
Copy link
Member

@tasomaniac The Hub does not have any cover photo information since this is not part of the data supplied by Devsite and there is no G+ API specific to retrieving Event data.

@tasomaniac
Copy link
Member Author

@mauimauer The colors are hardcoded. Actually these are not colors for events, but colors for event series.
I don't think there is an API for event series in Hub API. Like current ongoing event series. Right now, they are Study Jams, Women Techmakers.
If we have an event series feature in the future in the API, I want to get the color from the API.

@friedger
Copy link
Contributor

friedger commented Mar 2, 2015

@tasomaniac with a67c0e7 the event series are now correct and the popup are more readable. Still could be a different font color I guess.
device-2015-03-02-124521

@tasomaniac
Copy link
Member Author

@friedger Thank you. With that commit, the background of the items in the Toolbar is also fixed.
You can change the popup background with a style if you want to.

@mauimauer
Copy link
Member

@tasomaniac Event Series are just events with special tags. (ie. every event that has the WTM tag, is part of the WTM event series), thats how the Devsite (and thus the Hub) handles it.
(see https://hub.gdgx.io/api/v1/tags/android or https://hub.gdgx.io/api/v1/tags/wtm)

@friedger
Copy link
Contributor

friedger commented Mar 2, 2015

@mauimauer In the app or mabye on the website we would probably like to promote a tag for a period of time. That would require an API that returns the (tag, start date, end date, promo graphic)

@tasomaniac
Copy link
Member Author

@mauimauer @friedger That's what I was talking about. Promoting a event tag for a time and querying the current promoted tags.
In the code also, the special event names are refactored to TaggedEventSeries. That is also more consistent with what @mauimauer just said.

@tasomaniac
Copy link
Member Author

Comment about colors:
For now, we can keep the colors hardcoded but in the future release we can get the color of the tag dynamically from the Hub API.

@friedger
Copy link
Contributor

friedger commented Mar 2, 2015

Looks good. LGTM

@friedger
Copy link
Contributor

friedger commented Mar 2, 2015

Great effort!

friedger added a commit that referenced this pull request Mar 2, 2015
@friedger
Merge pull request #265 from gdg-x/feature/event-series-redesign
215cbb3 
Event series and event Fragment redesign
@friedger friedger merged commit 215cbb3 into develop Mar 2, 2015
@friedger friedger deleted the feature/event-series-redesign branch March 2, 2015 13:02
@friedger friedger mentioned this pull request Mar 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tasomaniac @HenriqueRocha @mauimauer @friedger