fixes #764 Adding tcell as a dependency delays startup time #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer bother to create the lookup table for runewidth. I had expected this to make a significant difference, but I'm finding that it does not, but it does make the startup time even for applications that only import and never create a screen, considerably worse. Dozens of milliseconds, even up to half a second. Applications that need this (persumably some heavy Emoji or EastAsian users) can solve for themselves by importing the runewidth package (same version) and calling the CreateLUT method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer bother to create the lookup table for runewidth. I had expected this to make a significant difference, but I'm finding that it does not, but it does make the startup time even for applications that only import and never create a screen, considerably worse. Dozens of milliseconds, even up to half a second.
Applications that need this (persumably some heavy Emoji or EastAsian users) can solve for themselves by importing the runewidth package (same version) and calling the CreateLUT method.