Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4279 - State store update wrapper for tests #4285

Merged
merged 18 commits into from
Feb 20, 2025
Merged

Issue 4279 - State store update wrapper for tests #4285

merged 18 commits into from
Feb 20, 2025

Conversation

patchwork01
Copy link
Collaborator

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • Updated existing tests

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

patchwork01 and others added 15 commits February 19, 2025 10:20
@patchwork01
Add StateStoreUpdatesWrapper.addFile...
77d8c78
@patchwork01
Use wrapper to add files in TransactionLogFileReferenceStoreTest
77b22b0
@patchwork01
Use wrapper to split files in TransactionLogFileReferenceStoreTest
652b8d2
@patchwork01
Introduce StateStoreUpdatesWrapper.assignJobIds
c1d8b35
@rtjd6554
Refactor atomicallyReplaceFileReferencesWithNewOnes into wrapper clas…
0c48ca6 
…s and update references
@patchwork01
Add StateStoreUpdatesWrapper.deleteGarbageCollectedFileReferenceCounts
34c80f3
@patchwork01
Add StateStoreUpdatesWrapper.clearSleeperTable
859ed6e
@patchwork01
Remove remaining update method references from TransactionLogFileRefe…
abfcce7 
…renceStoreTest
@patchwork01
Introduce StateStoreUpdatesWrapper.initialise
9564a9d
@rtjd6554
Move method to correct location in file
1ee06a0
@rtjd6554
Default method for new check of state before
5de500d
@rtjd6554
Relocate check before method
695bda6
@rtjd6554
Implement functionality for checkBefore
2f2b034
@rtjd6554
Update method call for wrapper
fc039e3
@rtjd6554
Update wrapper for split partitions nested class
d5c9683
@rtjd6554 rtjd6554 marked this pull request as ready for review February 20, 2025 11:36
@rtjd6554 rtjd6554 assigned rtjd6554 and unassigned patchwork01 Feb 20, 2025
@patchwork01 patchwork01 merged commit 4e3c3e9 into develop Feb 20, 2025
8 checks passed
@patchwork01 patchwork01 deleted the 4279-statestore-updates-for-tests branch February 20, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtjd6554 rtjd6554 rtjd6554 approved these changes

Assignees

@rtjd6554 rtjd6554

Labels
one-review-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State store wrapper for testing to preserve existing update methods
2 participants
@patchwork01 @rtjd6554