Skip to content

Commit

Permalink
Fix CompactionJobStatusFurthestStatusTest
Browse files Browse the repository at this point in the history
  • Loading branch information
patchwork01 committed Feb 20, 2025
1 parent 6ed08a1 commit a761d21
Showing 1 changed file with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import static sleeper.core.tracker.compaction.job.CompactionJobStatusTestData.compactionCommittedStatus;
import static sleeper.core.tracker.compaction.job.CompactionJobStatusTestData.compactionFinishedStatus;
import static sleeper.core.tracker.compaction.job.CompactionJobStatusTestData.compactionStartedStatus;
import static sleeper.core.tracker.compaction.job.CompactionJobStatusTestData.jobStatusFrom;
import static sleeper.core.tracker.compaction.job.CompactionJobStatusTestData.jobStatusFromUpdates;
import static sleeper.core.tracker.compaction.job.query.CompactionJobStatusType.CREATED;
import static sleeper.core.tracker.compaction.job.query.CompactionJobStatusType.FAILED;
Expand All @@ -40,6 +41,9 @@
import static sleeper.core.tracker.compaction.job.query.CompactionJobStatusType.UNCOMMITTED;
import static sleeper.core.tracker.job.run.JobRunSummaryTestHelper.summary;
import static sleeper.core.tracker.job.status.JobStatusUpdateTestHelper.failedStatus;
import static sleeper.core.tracker.job.status.TestJobStatusUpdateRecords.forRunOnTask;
import static sleeper.core.tracker.job.status.TestJobStatusUpdateRecords.onNoTask;
import static sleeper.core.tracker.job.status.TestJobStatusUpdateRecords.records;

public class CompactionJobStatusFurthestStatusTest {

Expand Down Expand Up @@ -157,7 +161,8 @@ void shouldReportJobSucceededWhenFollowedByAFailedRun() {
JobRunFailedStatus failed = failedStatus(started2, Duration.ofSeconds(30), List.of("Some failure"));

// When
CompactionJobStatus status = jobStatusFromUpdates(filesAssigned, started1, finished, committed, started2, failed);
CompactionJobStatus status = jobStatusFrom(records().fromUpdates(
onNoTask(filesAssigned), forRunOnTask(started1, finished, committed), forRunOnTask(started2, failed)));

// Then
assertThat(status.getFurthestStatusType()).isEqualTo(FINISHED);
Expand All @@ -178,7 +183,8 @@ void shouldReportJobInProgressWhenRetryingAfterFailure() {
Instant.parse("2023-03-22T15:37:01Z"));

// When
CompactionJobStatus status = jobStatusFromUpdates(filesAssigned, started1, failed, started2);
CompactionJobStatus status = jobStatusFrom(records().fromUpdates(
onNoTask(filesAssigned), forRunOnTask(started1, failed), forRunOnTask(started2)));

// Then
assertThat(status.getFurthestStatusType()).isEqualTo(IN_PROGRESS);
Expand Down

0 comments on commit a761d21

Please sign in to comment.