Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TSTV values in GafferPop Predicates #3236

Closed
p29876 opened this issue Jun 13, 2024 · 0 comments · Fixed by #3240
Closed

Support TSTV values in GafferPop Predicates #3236

p29876 opened this issue Jun 13, 2024 · 0 comments · Fixed by #3240
Assignees
@p29876
Labels
feature A proposed new feature tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.2

Comments

@p29876
Copy link
Member

p29876 commented Jun 13, 2024

Allow gremlin has querying for TSTV property values
e.g.
g.V().has("exampleProperty", "t:type|st:subtype|v:value")
@p29876 p29876 added tinkerpop Specific to/touches the tinkerpop module feature A proposed new feature labels Jun 13, 2024
@p29876 p29876 self-assigned this Jun 13, 2024
p29876 added a commit that referenced this issue Jun 14, 2024
@p29876
Gh-3236 Support TSTV values in GafferPop Predicates
b7d733a
@github-actions github-actions bot mentioned this issue Jun 14, 2024
Merged
wb36499 pushed a commit that referenced this issue Jun 19, 2024
@p29876
Gh-3236 Support TSTV values in GafferPop Predicates (#3240)
79e954f 
* Gh-3236 Support TSTV values in GafferPop Predicates

* Create custom GafferPopHasStep to handle querying TSTV properties

Needed when .has() is in the middle of a traversal rather than applied directly to the GraphStep

* testing

* sonarcloud

* more testing

* remove public

* spotbugs

* PR comments
@tb06904 tb06904 added this to the v2.2.2 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p29876 p29876

Labels
feature A proposed new feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Gh-3236 Support TSTV values in GafferPop Predicates gchq/Gaffer
2 participants
@tb06904 @p29876