Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TSTV seeded queries in GafferPop #3234

Closed
tb06904 opened this issue Jun 7, 2024 · 0 comments · Fixed by #3235
Closed

Support TSTV seeded queries in GafferPop #3234

tb06904 opened this issue Jun 7, 2024 · 0 comments · Fixed by #3235
Assignees
@tb06904
Labels
feature A proposed new feature tinkerpop Specific to/touches the tinkerpop module
Milestone
v2.2.2

Comments

@tb06904
Copy link
Member

tb06904 commented Jun 7, 2024

Describe the new feature you'd like
TypeSubTypeValue is a data type that can be used for IDs in Gaffer. We need to ensure that users can use TSTVs via Gremlin using GafferPop.

Additional context
The simplest way we could allow it would be treating them as String IDs in the form myType|mySubType|myValue and then parse them as TypeSubTypeValues once they've got through the server layer. Essentially so a user could do a seeded Gremlin query like: g.V("myType|mySubType|myValue").
@tb06904 tb06904 added tinkerpop Specific to/touches the tinkerpop module feature A proposed new feature labels Jun 7, 2024
@tb06904 tb06904 self-assigned this Jun 7, 2024
@GCHQDeveloper314 GCHQDeveloper314 added this to the v2.2.2 milestone Jun 7, 2024
tb06904 added a commit that referenced this issue Jun 10, 2024
@tb06904
Merge remote-tracking branch 'origin/develop' into gh-3234-tstv-seede…
45d53b2 
…d-queries-gremlin
@tb06904 tb06904 linked a pull request Jun 10, 2024 that will close this issue
Gh-3234: TypeSubTypeValue Seeded Query Support in GafferPop #3235
Merged
@github-actions github-actions bot mentioned this issue Jun 10, 2024
Merged
wb36499 pushed a commit that referenced this issue Jun 12, 2024
@tb06904
Gh-3234: TypeSubTypeValue Seeded Query Support in GafferPop (#3235)
e318993 
* add basic mechanism for TSTV seeds

* make method more generic

* add basic testing for seeded tstv queries

* whitespace

* move to regex matcher and new format

* update regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tb06904 tb06904

Labels
feature A proposed new feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Milestone
v2.2.2
Development

Successfully merging a pull request may close this issue.

Gh-3234: TypeSubTypeValue Seeded Query Support in GafferPop gchq/Gaffer
2 participants
@GCHQDeveloper314 @tb06904