Implement Blowfish CFB, OFB and CTR modes #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While CFB, OFB and CTR modes are available options for Blowfish Encrypt and Decrypt operations, internally only ECB and CBC modes were implemented. If a mode other than these two were chosen, it falls back to ECB mode. This results in #578, in which changing the IV has no effect with CFB mode selected, since it is actually operating with ECB mode, and the IV is not taken into account.
This PR retains the existing code for block encryption/decryption, and the modes are implemented using digitalbazaar/forge's implementations of general block cipher modes of operation. The outputs are tested against pyCryptoDome's Blowfish implementation.
This PR also updates some API tests in response to forge 0.9.1's explicit requirement of IV size.
I also made some redactions: