-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Node API #291
Implement Node API #291
Conversation
…ere it can be retrieved as various different data types.
Added test functionality for node api refactor TestRegister into class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Loads of work has gone into this. I'm really looking forward to using it!
There are really just a couple of things to sort out before this is ready to merge. I imagine that once it starts being used we will want to tweak it a little more, but I think it's largely ready for release.
@n1474335 Thanks for the comments - I'll address them later this week. |
Review comments have been address and I sorted out all the conflicts with |
@d98762625 Getting some broken node tests:
|
@n1474335 ew OK. What version of node are you running? I (and travis) are running |
v11.13.0 I've fixed them 👍 I'm not sure why they were ever passing actually, they certainly shouldn't have been. They were comparing a Dish with data in to a blank ArrayBuffer. |
Core wrapping of operations into a callable format has initial implementation.
help
function which returns info on operation. Currently accepts string, returns one operation's metadataTo do:
Recipe
orchef.bake
implementation that takes recipe from web app JSON outputimport { fromBase32 } from 'cyberChef'
chef.translateTo
)result
object, which has type conversion -chef.translateTo
addedBugs
help
andbake
are not part of thechef
object - only in.default
.To check before release:
string
could bevalue
Feedback:
help
could use search in the same way as the UI. Check for logic. e.g.chef.help("base64")
and get a sensible answer.bake
is forgiving: accept "to base 64", "tobase64", etc. Use default args if none specified.Future issues:
help
, so you can dochef.help(chef.toBase32)
search
functionalityrun
tohelp
output