Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also need to add pure annotations to the classes defined in
index.js
, however we can't add the pure annotation in the correct position because these are transpiled to IIFEs.For example:
monocle-ts/src/index.ts
Line 1465 in 9bd7fa6
This will become:
The pure annotation needs to be added like so:
I believe this can be solved by using a Babel plugin that adds the pure annotation to output of TypeScript. Alternatively, we can disable class transpilation.
Pure annotations are very easy to miss and hard to get right, so perhaps we should automate this across the fp-ts ecosystem, using something like one of these tools. WDYT @gcanti?