Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapnik server can crash #65

Closed
MattBlissett opened this issue Sep 15, 2022 · 4 comments
Closed

Mapnik server can crash #65

MattBlissett opened this issue Sep 15, 2022 · 4 comments

Comments

@MattBlissett
Copy link
Member

The server crashes after this exception:

Trace: Error: end of buffer exception
    at renderTile (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:31:6)
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:77:31
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1135:9
    at eachOfArrayLike (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1069:9)
    at eachOf (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1117:5)
    at _asyncMap (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1133:5)
    at Object.map (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1122:16)
    at heatMapRender (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:76:9)
    at module.exports (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:148:5)
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/server.js:54:13
    at process.<anonymous> (/usr/local/gbif/services/mapnik-server/0.32/1654094130/server.js:149:13)
    at emitOne (events.js:116:13)
    at process.emit (events.js:211:7)
    at process._fatalException (bootstrap_node.js:391:26)
Trace: Error: end of buffer exception
    at renderTile (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:31:6)
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:77:31
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1135:9
    at eachOfArrayLike (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1069:9)
    at eachOf (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1117:5)
    at _asyncMap (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1133:5)
    at Object.map (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1122:16)
    at heatMapRender (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:76:9)
    at module.exports (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:148:5)
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/server.js:54:13
    at process.<anonymous> (/usr/local/gbif/services/mapnik-server/0.32/1654094130/server.js:149:13)
    at emitOne (events.js:116:13)
    at process.emit (events.js:211:7)
    at process._fatalException (bootstrap_node.js:391:26)
@MattBlissett
Copy link
Member Author

Fixed in dd0cfdc

@MattBlissett
Copy link
Member Author 

(node:15614) Warning: No such label 'Get http://api.gbif.org:80/v2/map/occurrence/density/4/15/3.mvt?bin=hex&hexPerTile=15&taxonKey=5299694&srs=EPSG%3A4326' for console.timeEnd()
(node:15614) Warning: No such label 'Get http://api.gbif.org:80/v2/map/occurrence/density/4/17/3.mvt?bin=hex&hexPerTile=15&taxonKey=5299694&srs=EPSG%3A4326' for console.timeEnd()
Trace: Error: end of buffer exception
    at renderTile (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:31:6)
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:77:31
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1135:9
    at eachOfArrayLike (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1069:9)
    at eachOf (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1117:5)
    at _asyncMap (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1133:5)
    at Object.map (/usr/local/gbif/services/mapnik-server/0.32/1654094130/node_modules/async/dist/async.js:1122:16)
    at heatMapRender (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:76:9)
    at module.exports (/usr/local/gbif/services/mapnik-server/0.32/1654094130/renderer.js:148:5)
    at /usr/local/gbif/services/mapnik-server/0.32/1654094130/server.js:55:15
    at process.<anonymous> (/usr/local/gbif/services/mapnik-server/0.32/1654094130/server.js:161:13)
    at emitOne (events.js:116:13)
    at process.emit (events.js:211:7)
    at process._fatalException (bootstrap_node.js:391:26)

Hmm.

@MattBlissett MattBlissett reopened this Oct 1, 2022
@MattBlissett
Copy link
Member Author

Again:

Trace: Error: end of buffer exception
    at renderTile (/usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:31:6)
    at /usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:77:31
    at /usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1135:9
    at eachOfArrayLike (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1069:9)
    at eachOf (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1117:5)
    at _asyncMap (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1133:5)
    at Object.map (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1122:16)
    at heatMapRender (/usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:76:9)
    at module.exports (/usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:148:5)
    at /usr/local/gbif/services/mapnik-server/0.35/1679409013/server.js:55:15
    at process.<anonymous> (/usr/local/gbif/services/mapnik-server/0.35/1679409013/server.js:161:13)
    at emitOne (events.js:116:13)
    at process.emit (events.js:211:7)
    at process._fatalException (bootstrap_node.js:391:26)
Trace: Error: end of buffer exception
    at renderTile (/usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:31:6)
    at /usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:77:31
    at /usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1135:9
    at eachOfArrayLike (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1069:9)
    at eachOf (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1117:5)
    at _asyncMap (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1133:5)
    at Object.map (/usr/local/gbif/services/mapnik-server/0.35/1679409013/node_modules/async/dist/async.js:1122:16)
    at heatMapRender (/usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:76:9)
    at module.exports (/usr/local/gbif/services/mapnik-server/0.35/1679409013/renderer.js:148:5)
    at /usr/local/gbif/services/mapnik-server/0.35/1679409013/server.js:55:15
    at process.<anonymous> (/usr/local/gbif/services/mapnik-server/0.35/1679409013/server.js:161:13)
    at emitOne (events.js:116:13)
    at process.emit (events.js:211:7)

MortenHofft added a commit that referenced this issue May 14, 2024
@MortenHofft
close #65
20c3e7d
@MortenHofft
Copy link
Member

I've tried to fix it by a try catch in the server file.

We could also have looked at fixing it closer to the source in renderer.js. Two places stand out to me as odd at first glance, but there might be a reason it is done like this. It does look odd though:

maps/mapnik-server/src/main/node/renderer.js

Line 79 in 20c3e7d

if (err) console.log('All rendered', results, err);

There might be good reasons why we continue despite errors (perhaps tiles outside boundaries or empty tiles are considered errors at this point and handled somehow subsequently)

Similarly this looks odd

maps/mapnik-server/src/main/node/renderer.js

Line 63 in 20c3e7d

if (err) console.log('One rendered', results, err);

If there is an error, then encode the result as a png?

MattBlissett pushed a commit that referenced this issue May 14, 2024
@MortenHofft @MattBlissett
close #65
7f69990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattBlissett @MortenHofft