Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add <cast_shadows> tag under the <include> tag #600

Open
ddengster opened this issue Jun 25, 2021 · 1 comment
Open

Proposal: Add <cast_shadows> tag under the <include> tag #600

ddengster opened this issue Jun 25, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ddengster
Copy link

ddengster commented Jun 25, 2021

Desired behavior

Add a <cast_shadows> tag under the <include> tag in SDF 1.8 to override the included model's cast_shadows values.

Alternatives considered

You could apply <cast_shadows> under the visuals of the included model but that would apply to all usages of the model.

Implementation suggestion

Value should be 0 or 1, similar to <static>. Default to 1.

Additional context

The need for this feature sprung from problems in lightmapping models. Models with lightmaps baked into them would render both the lightmapped shadows and the ignition light's shadows.

@ddengster ddengster added the enhancement New feature or request label Jun 25, 2021
@chapulina
Copy link
Contributor

Here's a more generic version of this issue: #128

I think it would be more valuable to have a generic method for overriding any tag than adding tag overrides as we need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants