Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override arbitrary parts of included models #128

Open
osrf-migration opened this issue Jul 13, 2016 · 4 comments
Open

override arbitrary parts of included models #128

osrf-migration opened this issue Jul 13, 2016 · 4 comments
Labels
enhancement New feature or request major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Dirk Thomas (Bitbucket: Dirk Thomas, GitHub: dirk-thomas).


Currently only the pose and the static flag can be overridden for an included model. It would be great if this would be possible for any element.

An example use case would be to override the visual material and give the model a different color.

Without this feature it is not possible to reuse an existing model without either:

  • converting it into a template (which you might not have write access to if it is a third-party model)
  • copy-n-paste it and then modify it (which is kind of sad)

The markup could look like this:

<include>
  <uri>model://reused-model</uri>
  <override>
    <!-- allow anything here which is valid in a normal model -->
  </override>
</include>

In order to determine if (nested) elements in the override section should be appended or actually override existing elements of the included model each tag (the tag name as well as its attributes) could be checked for equality. The override tag itself isn't necessary. The overriding elements could be direct children of include.

@osrf-migration
Copy link
Author

Original comment by Dirk Thomas (Bitbucket: Dirk Thomas, GitHub: dirk-thomas).


  • Edited issue description

1 similar comment
@osrf-migration
Copy link
Author

Original comment by Dirk Thomas (Bitbucket: Dirk Thomas, GitHub: dirk-thomas).


  • Edited issue description

@osrf-migration
Copy link
Author

Original comment by Peter Horak (Bitbucket: pchorak).


Another use case would be to override/perturb physics parameters (friction, inertia, etc.), which can be useful when looking at the effects of model error.

@osrf-migration
Copy link
Author

Original comment by Peter Horak (Bitbucket: pchorak).


Also related: question 2764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major
Projects
None yet
Development

No branches or pull requests

1 participant