Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make linters happy #709

Merged
merged 1 commit into from
Mar 18, 2025
Merged

make linters happy #709

merged 1 commit into from
Mar 18, 2025

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 18, 2025

🦟 Bug fix

Summary

Some linters errors were introduced here #380

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Mar 18, 2025
@j-rivero
Copy link
Contributor

Thanks!

@ahcorde ahcorde merged commit 630b477 into ros2 Mar 18, 2025
5 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/linters branch March 18, 2025 12:22
voshch pushed a commit to voshch/ros_gz that referenced this pull request Mar 19, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
(cherry picked from commit 630b477)
ahcorde added a commit that referenced this pull request Mar 20, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Mar 20, 2025
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants