Minor optimization to avoid dynamic casting in Gazebo callbacks #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
ahcorde
approved these changes
Feb 11, 2025
|
https://github.com/Mergifyio backport jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit f646d5c)
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit f646d5c) # Conflicts: # ros_gz_bridge/src/factory.hpp
This was referenced Feb 11, 2025
ahcorde
pushed a commit
that referenced
this pull request
Feb 12, 2025
#693) Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit f646d5c) Co-authored-by: Addisu Z. Taddese <[email protected]>
Dyst-0
pushed a commit
to Dyst-0/ros_gz
that referenced
this pull request
Feb 23, 2025
…bosim#692) Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Dyst-0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
The casting is done prior to creating the callback so it's done only once instead of in every invocation of the callback.
Test it
Should be covered by existing tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.