Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use both ROS package and message name for unique mappings #656

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Use both ROS package and message name for unique mappings #656

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86785d2
Use both ROS package and message name for unique mappings
oysstu Nov 26, 2024
a0f654d
Fix linter error (line width)
oysstu Nov 26, 2024
fddae4e
Merge branch 'ros2' into fix/unique_msgs_across_ros_packages
azeey Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use both ROS package and message name for unique mappings 
Signed-off-by: Øystein Sture <[email protected]>
  • Loading branch information
@oysstu
oysstu committed Nov 26, 2024
commit 86785d2117db9f3401e6c8027fa6c392994f85e6
2 changes: 1 addition & 1 deletion ros_gz_bridge/ros_gz_bridge/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def gz_type(self):
return f'gz::msgs::{self.gz_message_name}'

def unique(self):
return f'{self.gz_message_name.lower()}_{self.ros2_message_name.lower()}'
return f'{self.gz_message_name.lower()}_{self.ros2_package_name}_{self.ros2_message_name.lower()}'


def mappings(gz_msgs_ver):
Expand Down