-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor camera demo #634
Refactor camera demo #634
Conversation
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When RViz is opened the position of the camera is in the wrong position.
My suggestions here:
- The sdf file that we are using it's from gz-sim, and we need to define in the camera sensor the
gz_frame_id
tocamera_optical
- Then we need to add a static transfrom
<node pkg="tf2_ros" exec="static_transform_publisher" args="--frame-id camera_link --child-frame-id camera_link_optical --roll 1.570796327 --yaw 1.570796327" />
Let me know if you need some help and I can open a PR with the suggestions
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
To minimize changes, I used the default camera sensor frame in the static transform publisher so that we don't need to add any frame id and the example will still work with the default world. Here's the 3D scene with the updated camera position: |
Refactors the
camera
demo leveraging the latest improvements inros_gz
.Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.