-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor air pressure demo #632
Conversation
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see these errors:
[gz-3] Warning [Utils.cc:132] [/sdf/model[@name="force_torque_demo"]/link[@name="base_plate"]/static:<data-string>:L3]: XML Element[static], child of element[link], not defined in SDF. Copying[static] as children of [link].
[gz-3] Warning [Utils.cc:132] [/sdf/model[@name="force_torque_demo"]/link[@name="base_plate"]/static:<data-string>:L3]: XML Element[static], child of element[link], not defined in SDF. Copying[static] as children of [link].
rqt_topic is not able to show the value, maybe a bad topic configuration ? the readme shows how to read the value with cmd commands, maybe remove rqt_topic from the launch file ?
I think this is the issue that I mentioned in the description. Because of the QoS seetings of the publisher, |
These errors look unrelated to |
I created this draft PR ros-visualization/rqt_topic#51 to try to override the QoS in rqt_topic, but for now it's not working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to try these last 3 suggestions ?
I tried ros-visualization/rqt_topic#51 in combination with your three suggestions:
I'm getting the following issue:
It looks like there's an issue passing I also tried just passing the Independently of the bridge problem, why do we need to pass |
Signed-off-by: Carlos Agüero <[email protected]>
…os_gz into caguero/air_pressure_demo_v2
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to use upper case for 'true' otherwise the code was not working, is this happening to you ?
the clock
bridge is required by rqt_topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working without the clock bridge, I don't know what I was doing wrong.
You just need to use the new changes from @azeey. Otherwise LGTM
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Carlos Agüero <[email protected]>
Thanks, good to go again! |
@ahcorde , are you OK with the changes now? |
Refactors the
air_pressure
demo leveraging the latest improvements inros_gz
. If we're happy with it, I'll propagate the refactor to all the demos.Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.