Update README.md to fix humble from source instructions #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the branch name when checking out ros_gz otherwise `rosdep install -r --from-paths src -i -y --rosdistro humble` errors with incompatible versions. Additonally link to gazebosim#401 (comment) which allows compilation on Ubuntu 20.04 + ROS2 Humble + Ignition Fortress Signed-off-by: Samuel Seng <[email protected]>
ahcorde
requested changes
Jun 23, 2023
| @@ -122,6 +122,22 @@ The following steps are for Linux and OSX. | |||
| colcon build | |||
| ``` | |||
|
|
|||
| If `colcon build` fails with [this issue](https://github.com/gazebosim/ros_gz/issues/401) | |||
There was a problem hiding this comment.
if you run the rosdep command this should not happen, maybe a better option is to install this dependency via deps:
sudo apt-get install ros-<ROS_DISTRO>-actuators-msgsThere was a problem hiding this comment.
This is for a Tier 3 install of ROS Humble on Ubtuntu 20.04 so any of ros-humble-* won’t exist. The issue occurs even if you rosdep install
ahcorde
approved these changes
Aug 21, 2023
|
@osrf-jenkins run tests please! |
|
I think that the test failure can be ignored here? This is just a documentation update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes N/A
Summary
Fix the branch name when checking out ros_gz otherwise
rosdep install -r --from-paths src -i -y --rosdistro humbleerrors with incompatible versions. Additonally link to #401 (comment) which allows compilation on Ubuntu 20.04 + ROS2 Humble + Ignition FortressChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.