Merge 96ce3c0 into 5d88091

.github/CODEOWNERS

@@ -2,4 +2,3 @@
 # https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
 
 *                     @caguero
-tutorials/*           @maryaB-osr

.github/ci/packages.apt

@@ -1,6 +1,6 @@
 libignition-cmake2-dev
 libignition-math6-dev
-libignition-msgs5-dev
+libignition-msgs6-dev
 libignition-tools-dev
 libprotobuf-dev
 libprotoc-dev

CMakeLists.txt

@@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.10.2 FATAL_ERROR)
 #============================================================================
 # Initialize the project
 #============================================================================
-project(ignition-transport8 VERSION 8.2.0)
+project(ignition-transport9 VERSION 9.1.0)
 
 #============================================================================
 # Find ignition-cmake
@@ -76,8 +76,8 @@ endif()
 
 #--------------------------------------
 # Find ignition-msgs
-ign_find_package(ignition-msgs5 REQUIRED VERSION 5.6)
-set(IGN_MSGS_VER ${ignition-msgs5_VERSION_MAJOR})
+ign_find_package(ignition-msgs6 REQUIRED VERSION 6.2)
+set(IGN_MSGS_VER ${ignition-msgs6_VERSION_MAJOR})
 
 #--------------------------------------
 # Find ifaddrs

Changelog.md

@@ -1,4 +1,69 @@
-## Ignition Transport 8
+## Ignition Transport 9.X
+
+### Ignition Transport 9.X.X
+
+### Ignition Transport 9.1.0 (2021-01-05)
+
+1. All changes up to version 8.2.0.
+
+### Ignition Transport 9.0.0 (2020-09-29)
+
+1. Fix link in "development" tutorial.
+   * [Github pull request 183](https://github.com/ignitionrobotics/ign-transport/pull/183)
+
+1. Remove contribute tutorial.
+   * [Github pull request 182](https://github.com/ignitionrobotics/ign-transport/pull/182)
+
+1. Update link to the tutorials.
+   * [Github pull request 181](https://github.com/ignitionrobotics/ign-transport/pull/181)
+
+1. Use private access modifier for pImpl variable in MsgIter class.
+   * [Github pull request 179](https://github.com/ignitionrobotics/ign-transport/pull/179)
+
+1. Remove deprecations before 9.x.x release.
+   * [Github pull request 175](https://github.com/ignitionrobotics/ign-transport/pull/175)
+
+1. Make CPPZMQ a PUBLIC dependency.
+   * [Github pull request 173](https://github.com/ignitionrobotics/ign-transport/pull/173)
+
+1. Update codeowners.
+   * [Github pull request 163](https://github.com/ignitionrobotics/ign-transport/pull/163)
+
+1. Removed markdown-header.
+   * [Github pull request 161](https://github.com/ignitionrobotics/ign-transport/pull/161)
+
+1. Removed repeated installation instructions.
+   * [Github pull request 160](https://github.com/ignitionrobotics/ign-transport/pull/160)
+
+1. Need ignition-msgs version 6
+   * [Github pull request 149](https://github.com/ignitionrobotics/ign-transport/pull/149/files)
+
+1. Update link to repo.
+   * [Github pull request 142](https://github.com/ignitionrobotics/ign-transport/pull/142)
+
+1. Fix download link.
+   * [Github pull request 141](https://github.com/ignitionrobotics/ign-transport/pull/141)
+
+1. Workflow updates.
+   * [Github pull request 134](https://github.com/ignitionrobotics/ign-transport/pull/134)
+
+1. Add .gitignore.
+   * [Github pull request 128](https://github.com/ignitionrobotics/ign-transport/pull/128)
+
+1. Update BitBucket links.
+   * [Github pull request 125](https://github.com/ignitionrobotics/ign-transport/pull/125)
+
+## Ignition Transport 8.X
+
+### Ignition Transport 8.X.X
+
+### Ignition Transport 8.2.0 (2020-01-05)
+
+1. All changes up to version 7.5.1.
+
+1. Addition of topic statistics that can report number of dropped messages
+   and publication, age, and reception statistics.
+    * [Pull request 205](https://github.com/ignitionrobotics/ign-transport/pull/205)
 
 ### Ignition Transport 8.2.0 (2020-01-05)
 
@@ -10,6 +75,18 @@
 
 ### Ignition Transport 8.1.0 (2020-08-28)
 
+1. Fix mem leak.
+   * [Github pull request 174](https://github.com/ignitionrobotics/ign-transport/pull/174)
+
+1. One NodeShared per process.
+    * [Github pull request 152](https://github.com/ignitionrobotics/ign-transport/pull/152)
+
+1. Remove Windows warnings.
+    * [Github pull request 151](https://github.com/ignitionrobotics/ign-transport/pull/151)
+
+1. Remove warnings on Homebrew.
+    * [Github pull request 150](https://github.com/ignitionrobotics/ign-transport/pull/150)
+
 1. Fix ByteSize deprecation warnings for Protobuf 3.1+.
     * [BitBucket pull request 423](https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-transport/pull-requests/423)
 
@@ -66,6 +143,15 @@
 
 ### Ignition Transport 7.5.0 (2020-07-29)
 
+1. Disable flaky Mac OS X tests
+    * [Pull request 176](https://github.com/ignitionrobotics/ign-transport/pull/176)
+
+1. Prevent empty messages from spamming the console
+    * [Pull request 164](https://github.com/ignitionrobotics/ign-transport/pull/164)
+
+1. Modernize actions CI
+    * [Pull request 158](https://github.com/ignitionrobotics/ign-transport/pull/158)
+
 1. Helper function to get a valid topic name
     * [Pull request 153](https://github.com/ignitionrobotics/ign-transport/pull/153)
 

Migration.md

@@ -6,6 +6,13 @@ Deprecated code produces compile-time warnings. These warning serve as
 notification to users that their code should be upgraded. The next major
 release will remove the deprecated code.
 
+## Ignition Transport 8.X to 9.X
+
+### Removed
+
+1. Remove deprecations before 9.x.x release
+    * [GitHub pull request 175](https://github.com/ignitionrobotics/ign-transport/pull/175)
+
 ## Ignition Transport 7.X to 8.X
 
 ### Deprecated

README.md

@@ -9,34 +9,34 @@
 
 Build | Status
 -- | --
-Test coverage | [![codecov](https://codecov.io/gh/ignitionrobotics/ign-transport/branch/ign-transport8/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/ign-transport)
-Ubuntu Bionic | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport8-bionic-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport8-bionic-amd64)
-Homebrew      | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport8-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport8-homebrew-amd64)
-Windows       | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport8-windows7-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport8-windows7-amd64)
+Test coverage | [![codecov](https://codecov.io/gh/ignitionrobotics/ign-transport/branch/ign-transport9/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/ign-transport)
+Ubuntu Bionic | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport9-bionic-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-master-bionic-amd64)
+Homebrew      | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport9-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-master-homebrew-amd64)
+Windows       | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-ign-transport9-windows7-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-master-windows7-amd64)
 
 Ignition Transport, a component of [Ignition Robotics](https://ignitionrobotics.org), provides fast and efficient asyncronous message passing, services, and data logging.
 
 # Table of Contents
 
-[Features](#markdown-header-features)
+[Features](#features)
 
-[Install](#markdown-header-install)
+[Install](#install)
 
-* [Binary Install](#markdown-header-binary-install)
+[Usage](#usage)
 
-* [Source Install](#markdown-header-source-install)
+[Documentation](#documentation)
 
-[Usage](#markdown-header-usage)
+[Testing](#testing)
 
-[Folder Structure](#markdown-header-folder-structure)
+[Folder Structure](#folder-structure)
 
-[Code of Conduct](#markdown-header-code-of-conduct)
+[Contributing](#contributing)
 
-[Contributing](#markdown-header-code-of-contributing)
+[Code of Conduct](#code-of-conduct)
 
-[Versioning](#markdown-header-versioning)
+[Versioning](#versioning)
 
-[License](#markdown-header-license)
+[License](#license)
 
 # Features
 
@@ -55,33 +55,12 @@ combination of custom code and ZeroMQ.
 
 # Install
 
-We recommend following the [Binary Install](#markdown-header-binary-install)
-instructions to get up and running as quickly and painlessly as possible.
-
-The [Source Install](#markdown-header-source-install) instructions should be
-used if you need the very latest software improvements, you need to modify the
-code, or you plan to make a contribution.
-
-## Binary Install
-
-On Ubuntu systems, `apt-get` can be used to install `ignition-transport`:
-
-```
-$ sudo apt install libignition-transport<#>-dev
-```
-
-Be sure to replace `<#>` with a number value, such as `1` or `2`, depending on
-which version you need.
-
-## Source Install
-
-See the [install](https://ignitionrobotics.org/api/transport/8.0/installation.html)
-section of the documentation.
+See the [installation tutorial](https://ignitionrobotics.org/api/transport/9.0/installation.html).
 
 # Usage
 
-See [tutorials](https://ignitionrobotics.org/api/transport/8.0/tutorials.html)
-and the [example directory](https://github.com/ignitionrobotics/ign-transport/blob/ign-transport8/example/)
+See [tutorials](https://ignitionrobotics.org/api/transport/9.0/tutorials.html)
+and the [example directory](https://github.com/ignitionrobotics/ign-transport/blob/ign-transport9/example/)
 in the source code.
 
 ## Known issue of command line tools

configure.bat

@@ -6,7 +6,7 @@
 :: Install dependencies
 call %win_lib% :download_unzip_install libzmq-4.2.3_cppzmq-4.2.2_vc15-x64-dll-MD.zip
 call %win_lib% :download_unzip_install sqlite-3.22.0-vc15-Win64-dll-MD.zip
-call %win_lib% :install_ign_project ign-msgs ign-msgs5
+call %win_lib% :install_ign_project ign-msgs ign-msgs6
 
 :: Set configuration variables
 @set build_type=Release

docker/ign-transport/Dockerfile

@@ -72,11 +72,11 @@ RUN sudo /bin/sh -c 'echo "deb [trusted=yes] http://packages.osrfoundation.org/g
  && sudo apt-get install -y \
     libignition-cmake2-dev \
     libignition-math6-dev \
-    libignition-msgs5-dev \
+    libignition-msgs6-dev \
  && sudo apt-get clean
 
 # Ignition transport
-RUN hg clone http://bitbucket.org/ignitionrobotics/ign-transport -b ign-transport8 \
+RUN git clone https://github.com/ignitionrobotics/ign-transport.git \
  && cd ign-transport \
  && mkdir build \
  && cd build \

example/CMakeLists.txt

@@ -3,8 +3,8 @@ cmake_minimum_required(VERSION 3.10.2 FATAL_ERROR)
 project(ignition-transport-examples)
 
 # Find the Ignition_Transport library
-find_package(ignition-transport8 QUIET REQUIRED OPTIONAL_COMPONENTS log)
-set(IGN_TRANSPORT_VER ${ignition-transport8_VERSION_MAJOR})
+find_package(ignition-transport9 QUIET REQUIRED OPTIONAL_COMPONENTS log)
+set(IGN_TRANSPORT_VER ${ignition-transport9_VERSION_MAJOR})
 
 if (EXISTS "${CMAKE_SOURCE_DIR}/msgs/")
   # Message generation. Only required when using custom Protobuf messages.

example/configure.bat

@@ -15,7 +15,7 @@
 @set IGNITION-MATH_CMAKE_PREFIX_PATH=%IGNITION-MATH_PATH%\CMake
 
 cmake -G "NMake Makefiles"^
-      -DCMAKE_PREFIX_PATH="%IGN_TRANSPORT_PATH%\lib\cmake\ignition-transport8;%IGNITION-MSGS_CMAKE_PREFIX_PATH%;%IGNITION-MATH_CMAKE_PREFIX_PATH%;"^
+      -DCMAKE_PREFIX_PATH="%IGN_TRANSPORT_PATH%\lib\cmake\ignition-transport9;%IGNITION-MSGS_CMAKE_PREFIX_PATH%;%IGNITION-MATH_CMAKE_PREFIX_PATH%;"^
       -DPROTOBUF_SRC_ROOT_FOLDER="%PROTOBUF_PATH%"^
       -DIGNITION-MSGS_FOLDER="%IGNITION-MSGS_PATH%"^
       -DCMAKE_INSTALL_PREFIX="install"^

include/ignition/transport/AdvertiseOptions.hh

@@ -114,22 +114,6 @@ namespace ignition
       /// \sa Scope_t.
       public: void SetScope(const Scope_t &_scope);
 
-      /// \brief Serialize the options. The caller has ownership of the
-      /// buffer and is responsible for its [de]allocation.
-      /// \param[out] _buffer Destination buffer in which the options
-      /// will be serialized.
-      /// \return Number of bytes serialized.
-      public: size_t IGN_DEPRECATED(8) Pack(char *_buffer) const;
-
-      /// \brief Deserialize and set the options. The input buffer is
-      /// unpacked and used to set this object's options.
-      /// \param[in] _buffer Input buffer with the data to be deserialized.
-      public: size_t IGN_DEPRECATED(8) Unpack(const char *_buffer);
-
-      /// \brief Get the total length of the message.
-      /// \return Return the length of the message in bytes.
-      public: size_t IGN_DEPRECATED(8) MsgLength() const;
-
 #ifdef _WIN32
 // Disable warning C4251 which is triggered by
 // std::unique_ptr
@@ -213,21 +197,6 @@ namespace ignition
       /// \param[in] _newMsgsPerSec Maximum number of messages per second.
       public: void SetMsgsPerSec(const uint64_t _newMsgsPerSec);
 
-      /// \brief Serialize the options. The caller has ownership of the
-      /// buffer and is responsible for its [de]allocation.
-      /// \param[out] _buffer Destination buffer in which the options
-      /// will be serialized.
-      /// \return Number of bytes serialized.
-      public: size_t IGN_DEPRECATED(8) Pack(char *_buffer) const;
-
-      /// \brief Unserialize the options.
-      /// \param[in] _buffer Input buffer with the data to be unserialized.
-      public: size_t IGN_DEPRECATED(8) Unpack(const char *_buffer);
-
-      /// \brief Get the total length of the message.
-      /// \return Return the length of the message in bytes.
-      public: size_t IGN_DEPRECATED(8) MsgLength() const;
-
 #ifdef _WIN32
 // Disable warning C4251 which is triggered by
 // std::unique_ptr
@@ -285,21 +254,6 @@ namespace ignition
         return _out;
       }
 
-      /// \brief Serialize the options. The caller has ownership of the
-      /// buffer and is responsible for its [de]allocation.
-      /// \param[out] _buffer Destination buffer in which the options
-      /// will be serialized.
-      /// \return Number of bytes serialized.
-      public: size_t IGN_DEPRECATED(8) Pack(char *_buffer) const;
-
-      /// \brief Unserialize the options.
-      /// \param[in] _buffer Input buffer with the data to be unserialized.
-      public: size_t IGN_DEPRECATED(8) Unpack(const char *_buffer);
-
-      /// \brief Get the total length of the message.
-      /// \return Return the length of the message in bytes.
-      public: size_t IGN_DEPRECATED(8) MsgLength() const;
-
 #ifdef _WIN32
 // Disable warning C4251 which is triggered by
 // std::unique_ptr