Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved doxygen #996

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Improved doxygen #996

merged 2 commits into from
Aug 26, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 25, 2021

🦟 Bug fix

Fixes #

Summary

Improved doxygen, This PR gazebosim/gz-cmake#183 in ign-cmake2 will fix more warnings.

I didn't activate the linter because there are still some warnings to fix.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde self-assigned this Aug 25, 2021
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #996 (05cde58) into ign-gazebo3 (d94d585) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 05cde58 differs from pull request most recent head 78e009b. Consider uploading reports for the commit 78e009b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #996   +/-   ##
============================================
  Coverage        77.84%   77.84%           
============================================
  Files              221      221           
  Lines            12687    12687           
============================================
  Hits              9876     9876           
  Misses            2811     2811           
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/ContactSensor.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
...nclude/ignition/gazebo/components/LogicalCamera.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh 90.32% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <0.00%> (ø)
src/gui/plugins/modules/EntityContextMenu.hh 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94d585...78e009b. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just some smaller comments.

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde merged commit c625586 into ign-gazebo3 Aug 26, 2021
@ahcorde ahcorde deleted the ahcorde/improve/doxygen branch August 26, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants