-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ign-sensors and support custom sensors #617
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
…itionrobotics/ign-gazebo into chapulina/5/ign-plugin_sensors Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment about the place to change the flag. I tested locally and all system plugins are failing.
Don't merge the other related PR yet until we are sure we can use this solution.
Removing beta label, we won't have time to wrap this up before code freeze. Let's retarget at Ignition-F. |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
The |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 64.66% 64.35% -0.31%
==========================================
Files 242 245 +3
Lines 19014 19217 +203
==========================================
+ Hits 12296 12368 +72
- Misses 6718 6849 +131
Continue to review full report at Codecov.
|
The 23 test failures on Jenkins Ubuntu are due to gazebo-tooling/release-tools#494 and can be ignored for now. #971 should fix them if we don't fix it in the infra. The rest of CI looks good. Merging! |
Part of gazebosim/gz-sensors#18
Summary
Requires gazebosim/gz-plugin#35 and gazebosim/gz-sensors#90.
This is an alternative to #304.
tl;dr: Loading symbols globally is a way of making we find them after they've been registered by another library.
TODO: write up a summary of what I think is happening.
Test it
ign gazebo sensors.sdf
orign gazebo sensors_demo.sdf
Checklist
codecheck
passed (See contributing)another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge