Rename Ogre2IgnHlmsCustomizations to Ogre2IgnHlmsSphericalClipMinDistance #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to Ogre2IgnHlmsSphericalClipMinDistance Signed-off-by: Matias N. Goldberg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 53.39% 53.38% -0.01%
==========================================
Files 211 211
Lines 20817 20818 +1
==========================================
- Hits 11115 11114 -1
- Misses 9702 9704 +2
Continue to review full report at Codecov.
|
Fix deprecation warnings Signed-off-by: Matias N. Goldberg <[email protected]>
iche033
reviewed
Jan 10, 2022
| @@ -175,9 +175,13 @@ namespace ignition | |||
| /// \return a list of FSAA levels | |||
| public: std::vector<unsigned int> FSAALevels() const; | |||
|
|
|||
| /// \brief Deprecated. Use SphericalClipMinDistance instead | |||
| public: Ogre2IgnHlmsSphericalClipMinDistance IGN_DEPRECATED(7) & | |||
There was a problem hiding this comment.
can you add an entry to the Migration.md guide?
There was a problem hiding this comment.
I'll add this in a separate PR
iche033
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part of ticket #502
In order to split the amount of changes into maneagable, reviewable changes; the changes are being submitted in 3 PRs.
This is the 2nd PR.
It simply renames Ogre2IgnHlmsCustomizations to Ogre2IgnHlmsSphericalClipMinDistance.
The reason behind this is that customizations are now being managed by Ogre2IgnHlmsPbs & Ogre2IgnHlmsUnlit.
Since Ogre2IgnHlmsCustomizations is doing just one job but has a generic name, it would tend to confusion as to what it does and its role.
The class isn't exposed to the user; however
Ogre2RenderEngine::HlmsCustomizationsdid expose a forward declared pointer to the user; which is why the function still exists but has been marked as deprecated.Signed-off-by: Matias N. Goldberg [email protected]
🦟 Bug fix
Affects #502
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.