Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 to 4 20210122 #208

Merged
merged 3 commits into from
Jan 22, 2021
Merged

3 to 4 20210122 #208

merged 3 commits into from
Jan 22, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jan 22, 2021

Merge 3 in to 4.

mabelzhang and others added 3 commits January 20, 2021 17:46
Signed-off-by: Mabel Zhang <[email protected]>

Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from iche033 January 22, 2021 21:26
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #208 (0d068e5) into ign-rendering4 (7e8a384) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #208   +/-   ##
===============================================
  Coverage           52.59%   52.59%           
===============================================
  Files                 143      143           
  Lines               13341    13341           
===============================================
  Hits                 7017     7017           
  Misses               6324     6324           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8a384...0d068e5. Read the comment docs.

@nkoenig nkoenig merged commit 31368aa into ign-rendering4 Jan 22, 2021
@nkoenig nkoenig deleted the 3_to_4-20210122 branch January 22, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants