-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dartsim] Add support for joint frame semantics #288
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename the test KinematicsFeaturs_TEST.cc
-> KinematicsFeatures_TEST.cc
otherwise looks good
Codecov Report
@@ Coverage Diff @@
## ign-physics2 #288 +/- ##
================================================
- Coverage 83.21% 83.16% -0.06%
================================================
Files 106 106
Lines 4040 4051 +11
================================================
+ Hits 3362 3369 +7
- Misses 678 682 +4
Continue to review full report at Codecov.
|
Signed-off-by: Addisu Z. Taddese <[email protected]>
Done in 96298c4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, I ran the test with the changes to Base.hh
reverted and got an exception somewhere:
[ RUN ] KinematicsFeaturesFixture.JointFrameSemantics
unknown file: Failure
C++ exception with description "unordered_map::at: key not found" thrown in the test body.
[ FAILED ] KinematicsFeaturesFixture.JointFrameSemantics (83 ms)
With --gtest_catch_exceptions=0
, I was able to get a backtrace implicating this line in KinematicsFeatures::SelectFrame
. If you think it would be easy to improve the console output in this situation and worth fixing now, then go ahead, but otherwise it's fine as is
Signed-off-by: Addisu Z. Taddese <[email protected]>
I added a console message and an assertion in 5f2bbe2 following the pattern that was already there in |
🎉 New feature
Summary
Since joints in DART are not considered frames, this adds
dart::dynamics::SimpleFrame
attached to the child body of a joint and offset from the child by the pose of the joint.Test it
Run
UNIT_KinematicsFeatures_TEST
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge