Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Python3_Development_FOUND checks #663

Open
wants to merge 2 commits into
base: gz-math7
Choose a base branch
from

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes hidden warnings when python development libraries are not found, backport of #662

Summary

The value of Python3_Development_FOUND may change if other code paths call find_package(Python3), so move the warning to be co-located with the add_subdirectory call. Otherwise python bindings may be silently ignored.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The value of this variable may change if other code paths
call find_package(Python3), so move the warning to be
co-located with the add_subdirectory call.

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Feb 10, 2025
@scpeters
Copy link
Member Author

I opened #665 to test CI with prereleases, and it has the same commit hashes, so it is rewriting the build status

if these CI checks pass, then we know the cmake warning will be fixed by the next gz-cmake3 stable release

@scpeters
Copy link
Member Author

I opened #665 to test CI with prereleases, and it has the same commit hashes, so it is rewriting the build status

if these CI checks pass, then we know the cmake warning will be fixed by the next gz-cmake3 stable release

fixed! I will merge this, when we are ready for a stable release of gz-cmake3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants