Skip to content

Fix C4305 double truncated to float warnings (backport #666) #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gz-common6
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 25, 2025

🦟 Bug fix

Small fix, Windows warnings related to C4305 in a couple of tests.

Summary

C++ literals default to double, and Windows build it's complaining because EXPECT_FLOAT_EQ test macros are expecting the use of a float type. Changing the literals to use f, so they should be using float now.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #666 done by [Mergify](https://mergify.com).

Signed-off-by: Jorge J. Perez <[email protected]>
(cherry picked from commit 433d1cd)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants