Revert python to optional dependency #132
Conversation
Prior to #117, python was an optional dependency; this restores that behavior. * IgnPython: find PythonInterp with QUIET instead of REQUIRED * IgnCodeCheck: skip cpplint if python is not found Signed-off-by: Steve Peters <[email protected]>
github-actions
bot
added
🏢 edifice
There was a problem hiding this comment.
Looks good to me, thanks for catching this @scpeters!
I just opened gazebo-tooling/action-gz-ci#26 yesterday so that we can run make codecheck in GitHub actions instead of the old tools/code_check.sh where applicable, so that we are enforcing the new code checker introduced by #117. This PR shouldn't affect this change to GitHub actions since we only run Ubuntu Bionic on actions, right?
Also, does this mean we'll probably need to do another CMake release to fix homebrew CI? Or is just merging this PR sufficient enough?
We also run Focal from Citadel onwards, and @scpeters started adding macOS actions for some libraries, but that doesn't use
We could make a patch release, I think this fix should benefit Linux as well. |
yeah I think a patch release would be prudent. I'll open a version bump PR after merging this |
no worries; I reviewed and approved #117, so I missed it too |
The homebrew update for ignition-cmake 2.6.0 (osrf/homebrew-simulation#1222) has a failing bottle build:
It complains about being unable to find Python3. Prior to #117, there was a
find_package(PythonInterp QUIET)call inign_build_testswhen setting up thecheck_test_ran.pytest, but that was changed toREQUIRED. This reverts that change to restore python to an optional dependency and disables thecpplintportion ofmake codecheckif python is not available. We are already checking if python is found before using thecheck_test_ran.pyscript.The alternative to to make python3 a required dependency, which will require updates to the documentation and packaging metadata.