-
Notifications
You must be signed in to change notification settings - Fork 497
Test ABI compatibility of physics-sensor lockstep #2791
Conversation
… Add test world file. New test is passing. Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
…ailing Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
…imestamp Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Physics CameraSensor lockstep
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Physics lockstep for all sensors
ABI checker build is green! I think this PR is ready fro review :) |
Signed-off-by: Ian Chen <[email protected]>
small update to make lockstepping work for wide-angle cameras. b351913 |
ubuntu gpu-none has these test failures that are not in the buildfarm CI. They all seem related to timing: PhysicsEngines/ContactSensor.ModelRemoval/0
It's waiting for topic cleanup, and they aren't being cleaned up. PhysicsEngines/ImuTest.ImuSensorTestWorld/0
This is inside an else-if-condition SpeedThreadIslandsTest.MultiplePendulumQuickStep
It's comparing the time between threading and no threading. I could not reproduce any of these locally... I thought we had made the timing issue better with |
Ooh I'm seeing all these failures in #2788 as well: https://build.osrfoundation.org/job/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-none/240/ PhysicsEngines/ContactSensor.ModelRemoval/2 This is the same set as above. So they're just flaky. I think this PR is good to go then. |
lockstep is working with manual testing. ABI build is fine. Approving! |
hmm we should probably give this PR a better title before merging. |
xD Thanks for changing the title. Merging! |
Created this to trigger ABI checker on Jenkins correctly (hopefully).